Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #1792 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

[PATCH] Rails is not warnings-safe.

Reported by: drbrain Assigned to: David
Priority: normal Milestone:
Component: Railties Version: 0.13.1
Severity: normal Keywords:
Cc:

Description

ActiveSupport cannot be run with ruby -w. This patch fixes it.

There are still some 'method redefined' warnings, but they are OK because AS is reloading the files.

Attachments

1792.activesupport.warnings-safe.patch (1.6 kB) - added by eric@robotcoop.com on 07/20/05 20:08:35.
.2 (0 bytes) - added by eric@robotcoop.com on 07/20/05 22:57:37.
warning.megapatch (23.2 kB) - added by eric@robotcoop.com on 07/20/05 22:57:58.
warning.megapatch.2 (41.4 kB) - added by eric@robotcoop.com on 07/21/05 20:19:28.

Change History

07/20/05 20:08:35 changed by eric@robotcoop.com

  • attachment 1792.activesupport.warnings-safe.patch added.

07/20/05 22:57:25 changed by drbrain

  • component changed from ActiveSupport to RailTies.
  • summary changed from [PATCH] ActiveSupport is not warnings-safe. to [PATCH] Rails is not warnings-safe..

I'll just make it cover the whole dang thing.

The updated patch fixes many duplicated methods including apparent SVN repo corruption, method duplication due to not having the protection of -w, and a duplicated class name that's revealed by -w.

This patch is a work in progress, it doesn't yet pass all the tests. I'll trim the next rev down so it everything passes.

07/20/05 22:57:37 changed by eric@robotcoop.com

  • attachment .2 added.

07/20/05 22:57:58 changed by eric@robotcoop.com

  • attachment warning.megapatch added.

07/21/05 20:18:57 changed by drbrain

This patch version has a clean ActiveRecord and clean ActiveSupport.

07/21/05 20:19:28 changed by eric@robotcoop.com

  • attachment warning.megapatch.2 added.

11/21/05 07:06:36 changed by bitsweat

(In [3124]) Turn warnings on when loading a file if Dependencies.mechanism == :load. Common mistakes such as redefined methods will print warnings to stderr. References #752. References #1792.

11/21/05 07:29:55 changed by bitsweat

(In [3135]) r3241@asus: jeremy | 2005-11-20 23:26:28 -0800

Active Support is warnings-safe. References #1792.

02/18/07 03:30:31 changed by josh

  • status changed from new to closed.
  • resolution set to fixed.