Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #1434 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Make Routes Faster

Reported by: ulysses Assigned to: ulysses
Priority: normal Milestone:
Component: ActionPack Version: 0.12.1
Severity: normal Keywords: routes speed
Cc:

Description

This patch includes a complete rewrite of routes which increases the speed of both URL generation and recognition.

Attachments

routing-3.patch (96.6 kB) - added by Ulysses on 06/13/05 14:23:24.
First public patch
speedy-routes_rev_2.patch (97.3 kB) - added by Ulysses on 06/13/05 14:32:30.
Fixes handling of extra keys
speedy-routes_rev_4.patch (98.3 kB) - added by Ulysses on 06/13/05 15:39:07.
Patch including named routes
speedy-routes_rev_5.patch (98.6 kB) - added by Ulysses on 06/13/05 15:52:52.
Patch fixes named routes
speedy-routes_rev_6.patch (99.0 kB) - added by Ulysses on 06/13/05 20:36:33.
Patch which assumes defaults for action and id
speedy-routes_rev_7.patch (99.6 kB) - added by Ulysses on 06/13/05 21:45:42.
Patch for skaes that uses string keys
speedy-routes_rev_8.patch (99.7 kB) - added by Ulysses on 06/13/05 22:26:45.
Loose ends on using only strings
speedy-routes_rev_9.patch (99.8 kB) - added by Ulysses on 06/13/05 22:48:57.
Another step towards success…
speedy-routes_rev_10.patch (100.7 kB) - added by Ulysses on 06/22/05 12:30:59.
The patch I meant to upload
speedy-routes-new.patch (89.7 kB) - added by Ulysses on 06/22/05 17:57:36.
Patch fixing recognition bug
speedy-routes-new_rev_2.patch (98.6 kB) - added by Ulysses on 06/22/05 18:24:02.
Again…
speedy-routes-new_rev_3.patch (102.8 kB) - added by ulysses on 06/22/05 18:46:07.
speedy-routes-new_rev_4.patch (102.9 kB) - added by ulysses on 06/23/05 10:30:53.
speedy-routes-new_rev_5.patch (104.7 kB) - added by Ulysses on 06/24/05 13:16:47.
Mostly coding style fixes
speedy-routes-new_rev_6.patch (105.4 kB) - added by marcel on 06/24/05 16:33:19.
This should be the final version...(famous last words).
late-fixes.patch (0.9 kB) - added by ulysses on 06/24/05 17:44:45.
Fixes AP unit-tests

Change History

06/13/05 14:23:24 changed by Ulysses

  • attachment routing-3.patch added.

First public patch

06/13/05 14:32:30 changed by Ulysses

  • attachment speedy-routes_rev_2.patch added.

Fixes handling of extra keys

06/13/05 15:39:07 changed by Ulysses

  • attachment speedy-routes_rev_4.patch added.

Patch including named routes

06/13/05 15:52:52 changed by Ulysses

  • attachment speedy-routes_rev_5.patch added.

Patch fixes named routes

06/13/05 20:36:33 changed by Ulysses

  • attachment speedy-routes_rev_6.patch added.

Patch which assumes defaults for action and id

06/13/05 20:37:45 changed by ulysses

Rev 6 assumes defaults for action and id to maintain compatibilty with current routes.

If you tried this patch before and had problems, you will probably be more successfuly when trying again.

06/13/05 21:45:42 changed by Ulysses

  • attachment speedy-routes_rev_7.patch added.

Patch for skaes that uses string keys

06/13/05 22:26:45 changed by Ulysses

  • attachment speedy-routes_rev_8.patch added.

Loose ends on using only strings

06/13/05 22:48:57 changed by Ulysses

  • attachment speedy-routes_rev_9.patch added.

Another step towards success...

06/21/05 07:26:36 changed by david

  • summary changed from [XPATCH] Make Routes Faster to [PATCH] Make Routes Faster.

06/22/05 12:29:25 changed by ulysses

Revision 10 now uses string keys upon URL recognition. Since indifferent hashes are being used to hold the merged parameters, the use of string keys will save time when the keys are merged. (Indifferent hashes use string keys internally.)

However, it still uses symbols to generate urls, as in url_for :action => 'index' instead of 'action' => 'index'. This is done because inside we all hate strings and have a secret love affair with symbols.

This patch is now approaching completion, and revision 10 should work find against a SVN checkout. If it does not, please contact me on IRC.

06/22/05 12:30:59 changed by Ulysses

  • attachment speedy-routes_rev_10.patch added.

The patch I meant to upload

06/22/05 17:57:36 changed by Ulysses

  • attachment speedy-routes-new.patch added.

Patch fixing recognition bug

06/22/05 18:24:02 changed by Ulysses

  • attachment speedy-routes-new_rev_2.patch added.

Again...

06/22/05 18:46:07 changed by ulysses

  • attachment speedy-routes-new_rev_3.patch added.

06/23/05 10:30:53 changed by ulysses

  • attachment speedy-routes-new_rev_4.patch added.

06/24/05 13:16:47 changed by Ulysses

  • attachment speedy-routes-new_rev_5.patch added.

Mostly coding style fixes

06/24/05 16:33:19 changed by marcel

  • attachment speedy-routes-new_rev_6.patch added.

This should be the final version...(famous last words).

06/24/05 16:40:36 changed by david

  • status changed from new to closed.
  • resolution set to fixed.

06/24/05 17:44:45 changed by ulysses

  • attachment late-fixes.patch added.

Fixes AP unit-tests