Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11569 (new defect)

Opened 1 month ago

Last modified 1 month ago

[PATCH] continuous builder log message doesn't match author/revision number

Reported by: mainej Assigned to: core
Priority: normal Milestone: 2.x
Component: Plugins Version: edge
Severity: normal Keywords:
Cc:

Description

The emails generated by Continuous Builder (CB) have the commit author and revision number in the subject, but occasionally they don't match the commit log in the email body.

Here's how it happens...

# Commit 1 # CB does svn up and starts tests # Commit 2 (CB doesn't start, because Commit 1 has the lock) # CB finishes tests for Commit 1 and generates email

  • Author and revision number extracted from svn info
    • svn info pulls from working copy, i.e. Commit 1
  • Log extracted from svn log -rHEAD
    • svn log -rHEAD pulls from SVN server, i.e. Commit 2

Patch attached.

Attachments

correct_commit_message.diff (2.3 kB) - added by mainej on 04/10/08 23:19:35.
correct_commit_message.2.diff (2.3 kB) - added by mainej on 04/10/08 23:21:19.

Change History

04/10/08 22:32:11 changed by mainej

Properly formatted:

1. Commit 1
2. CB does svn up and starts tests
3. Commit 2 (CB doesn't start, because Commit 1 has the lock)
4. CB finishes tests for Commit 1 and generates email

  • Author and revision number extracted from svn info
    • svn info pulls from working copy, i.e. Commit 1
  • Log extracted from svn log -rHEAD
    • svn log -rHEAD pulls from SVN server, i.e. Commit 2

04/10/08 23:19:35 changed by mainej

  • attachment correct_commit_message.diff added.

04/10/08 23:21:19 changed by mainej

  • attachment correct_commit_message.2.diff added.

04/10/08 23:25:22 changed by mainej

Further research... The revision number is often incorrect.

We actually have no interest in the current SVN revision number (it could be a change to an entirely different app). We're only interested in the last change to this app. So, query and work with the Last Changed Revision instead of the Revision.

Use patch correct_commit_message.2.diff.