Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11559 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

Open ID Plugin Patch for 2.0.4

Reported by: markpercival Assigned to: josh
Priority: normal Milestone: 2.x
Component: Plugins Version: edge
Severity: normal Keywords:
Cc:

Description

The Open ID plugin is still giving me trouble with the latest Ruby-OpenID gem, 2.0.4. I fixed the issue I had with it, which was the a class name that changed from 1.x to 2.x.

OpenID::FilesystemStore should be OpenID::Store::Filesystem 

OpenID::Store::Filesystem.new(OPEN_ID_AUTHENTICATION_DIR)

Also, root_url is still in there. According to the changelog DHH took it out. I safely moved it to a seperate function that defaults to the host if root_url isn't set. 

def realm
  root_url || "#{request.protocol + request.host_with_port}"
end

Attachments

open_id_authentication.rb.diff (1.2 kB) - added by markpercival on 04/09/08 19:02:25.
Diff output for open_id_authentication.rb

Change History

04/09/08 19:02:25 changed by markpercival

  • attachment open_id_authentication.rb.diff added.

Diff output for open_id_authentication.rb

04/09/08 19:50:11 changed by josh

  • owner changed from core to josh.
  • status changed from new to assigned.

04/09/08 21:46:12 changed by markpercival

Sorry, in the realm method that should read 

def realm
  root_url ||= "#{request.protocol + request.host_with_port}"
end

04/10/08 04:51:59 changed by josh

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [9246]) Fixed OpenID file store class and safely fallback if there is no root_url. Closes #11559. [markpercival]