Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11501 (new defect)

Opened 2 months ago

Last modified 2 months ago

[PATCH] Ajax.Request.setRequestHeaders uses Object.isFunction(extras.push) instead of iObject.isArray(extras)

Reported by: jdalton Assigned to: sam
Priority: low Milestone: 2.x
Component: Prototype Version: edge
Severity: minor Keywords:
Cc:

Description

I don't know why but on line 155 in ajax.js getRequestHeaders does 

      if (Object.isFunction(extras.push))
        for (var i = 0, length = extras.length; i < length; i += 2) 
          headers[extras[i]] = extras[i+1];

Shouldn't it be: 

      if (Object.isArray(extras))
        for (var i = 0, length = extras.length; i < length; i += 2) 
          headers[extras[i]] = extras[i+1];

Attachments

setRequestHeaders_use_isArray.diff (494 bytes) - added by jdalton on 04/01/08 20:41:12.

Change History

04/01/08 20:40:47 changed by jdalton

correction setRequestHeaders not getRequestHeaders

04/01/08 20:41:12 changed by jdalton

  • attachment setRequestHeaders_use_isArray.diff added.