Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11475 (new defect)

Opened 2 months ago

Last modified 1 month ago

[PATCH][TEST] Better IFRAME Support in methods and others using elment.ownerDocument

Reported by: jdalton Assigned to: sam
Priority: normal Milestone: 2.x
Component: Prototype Version: edge
Severity: normal Keywords:
Cc:

Description

Executing Prototype code on Iframes is spotty. This is becuase most of the code references document.body or document or document.documentElement on the current page and not the iframe. I have fixed this by using element.ownerDocument.

You may use the tests here: http://dev.rubyonrails.org/ticket/9550

Attachments

iframe_patch.diff (7.4 kB) - added by jdalton on 03/31/08 05:27:04.

Change History

03/31/08 05:27:04 changed by jdalton

  • attachment iframe_patch.diff added.

03/31/08 05:29:06 changed by jdalton

  • summary changed from [PATCH] Better IFRAME Support to [PATCH][TESTS] Better IFRAME Support.

(follow-up: ↓ 5 ) 03/31/08 05:31:03 changed by jdalton

for the tests to work I had to reference this patch:
http://dev.rubyonrails.org/ticket/11473

04/02/08 00:59:49 changed by jdalton

  • summary changed from [PATCH][TESTS] Better IFRAME Support to [PATCH][TESTS] Better IFRAME Support in methods and others using elment.ownerDocument.

04/02/08 16:48:34 changed by jdalton

  • summary changed from [PATCH][TESTS] Better IFRAME Support in methods and others using elment.ownerDocument to [PATCH][TEST] Better IFRAME Support in methods and others using elment.ownerDocument.

(in reply to: ↑ 2 ) 04/03/08 08:32:21 changed by jdalton

Replying to jdalton:

for the tests to work I had to reference this patch:
http://dev.rubyonrails.org/ticket/11473


Correction the patch I referenced is:
http://dev.rubyonrails.org/ticket/11474

04/06/08 05:31:41 changed by jdalton

The methods 

Element._getDocument()
Element._getBodyElement()
Element._getDocumentElement()

Could be added to each element as 

element.getDocument();
element.getBody()
element.getDocumentElement()