Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11471 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

[PATCH] fcgi_handler doesn't get correctly restarted on SIGUSR2

Reported by: guillaume Assigned to: core
Priority: normal Milestone: 2.0.3
Component: Railties Version: edge
Severity: normal Keywords:
Cc:

Description

when sending SIGUSR2 on a idle fcgi rails process, this process will never be restarted as it would be. The signal is correctly received but the @when_ready variable is overrided on the next process_request(), and the restart! method is never reached. Here is a patch.

Tests have been updated too, to correctly handle signals with mocha.

Attachments

fcgi_handler_fix_and_tests_update.diff (2.4 kB) - added by guillaume on 03/30/08 21:14:19.
fcgi_processing.diff (2.1 kB) - added by bitsweat on 03/30/08 21:40:15.
fcgi_handler_tests_update.diff (3.0 kB) - added by guillaume on 04/03/08 19:44:59.

Change History

03/30/08 21:14:19 changed by guillaume

  • attachment fcgi_handler_fix_and_tests_update.diff added.

03/30/08 21:40:15 changed by bitsweat

  • attachment fcgi_processing.diff added.

03/30/08 23:07:55 changed by bitsweat

(In [9151]) Handle exit, reload, and restart immediately if not processing a request. References #11471 [guillaume, Jeremy Kemper]

03/30/08 23:40:02 changed by bitsweat

Needs test coverage before merging back to branches/2-0-stable

04/03/08 19:44:59 changed by guillaume

  • attachment fcgi_handler_tests_update.diff added.

04/03/08 20:00:36 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [9220]) Update fcgi dispatcher test cases. Closes #11471 [guillaume]