Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11453 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

[PATCH] set document.loaded = true before calling document.fire()

Reported by: choppsta Assigned to: sam
Priority: high Milestone: 2.x
Component: Prototype Version: edge
Severity: normal Keywords: 1.6.0.3
Cc:

Description

document.loaded is set after the dom:loaded event is fired, meaning that there is a period of time when the DOM is ready, but document.loaded incorrectly returns false.

A simple fix would be to move the document.loaded = true assignment to before the dom:loaded event is fired as follows: 

document.fire("dom:loaded");
document.loaded = true;

would become: 

document.loaded = true;
document.fire("dom:loaded");

Attachments

document_loaded_fix.diff (421 bytes) - added by jdalton on 03/29/08 08:24:05.
finally, :)

Change History

03/29/08 08:24:05 changed by jdalton

  • attachment document_loaded_fix.diff added.

finally, :)

03/29/08 08:24:52 changed by jdalton

  • keywords set to 1.6.0.3.
  • priority changed from normal to high.
  • summary changed from document.loaded improvement to [PATCH] set document.loaded = true before calling document.fire().

05/19/08 20:46:12 changed by jdalton

  • status changed from new to closed.
  • resolution set to fixed.

http://github.com/sstephenson/prototype/commit/c5f71a6e391fe647d81b4a4fdbcf54b64fbc88a3