Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11348 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

[PATCH] Add default command options when using cap shell.

Reported by: MetaSkills Assigned to: minam
Priority: normal Milestone: 2.x
Component: Capistrano Version: edge
Severity: normal Keywords: sudo capistrano default run options
Cc: jamis@37signals.com

Description

Previously for me all sudo commands failed on the shell and this fixed it. The patch will add the default command options to the when executing the command in the shell. So now I was able to add default_run_options[:pty] = true in my .caprc file and got all my sudo shell commands to work.

I also added a few tests to shell that Shell#exec_tasks and Shell#exec_command. It felt wrong to add any more tests to verify the default load optoins, not sure if the shell_test was the right place for it. Feedback welcome.

Attachments

default_command_options_for_shell.patch (1.8 kB) - added by MetaSkills on 03/14/08 02:17:50.
Patch for shell default command options and more shell tests.

Change History

03/14/08 02:17:50 changed by MetaSkills

  • attachment default_command_options_for_shell.patch added.

Patch for shell default command options and more shell tests.

03/14/08 03:14:51 changed by minam

  • summary changed from Add default command options when using cap shell. to [PATCH] Add default command options when using cap shell..

03/14/08 03:20:12 changed by minam

  • status changed from new to closed.
  • resolution set to fixed.

(In [9025]) Ensure that the default run options are mixed into the command options when executing a command from the cap shell (closes #11348)