Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11235 (closed enhancement: fixed)

Opened 4 months ago

Last modified 4 months ago

[PATCH] Refactor ActionController::Filters to use ActiveSupport::Callbacks

Reported by: josh Assigned to: bitsweat
Priority: normal Milestone: 2.x
Component: ActionPack Version: edge
Severity: normal Keywords:
Cc:

Description

[PATCH] Refactor ActionController::Filters to use ActiveSupport::Callbacks

http://github.com/josh/rails/tree/refactor_filters

Attachments

refactor_filters.diff (39.3 kB) - added by josh on 03/16/08 00:05:04.

Change History

(follow-up: ↓ 2 ) 02/27/08 22:04:34 changed by jamesh

I tried to apply this patch to a project using the 2.0 stable branch. The diff for activesupport/lib/active_support/callbacks.rb failed per the file not existing. I take it this is only for edge?

(in reply to: ↑ 1 ) 02/28/08 00:28:15 changed by josh

Replying to jamesh:

I tried to apply this patch to a project using the 2.0 stable branch. The diff for activesupport/lib/active_support/callbacks.rb failed per the file not existing. I take it this is only for edge?

Use patch level 1 for git patches. "curl ... | patch -p1".

03/16/08 00:05:04 changed by josh

  • attachment refactor_filters.diff added.

03/16/08 00:10:36 changed by josh

Okay Jeremy, shes ready to be committed.

03/18/08 17:56:11 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

(In [9055]) Refactor filters to use Active Support callbacks. Closes #11235.