Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11223 (closed enhancement: fixed)

Opened 6 months ago

Last modified 6 months ago

[PATCH] Added tests for testing RecordTagHelpers: div_for and content_tag_for

Reported by: thechrisoshow Assigned to: core
Priority: low Milestone: 2.x
Component: ActionPack Version: edge
Severity: minor Keywords: tests verified
Cc:

Description

The div_for and content_tag_for helpers don't have any tests.

This patch adds some miniscule tests for these methods.

Attachments

tests_for_record_tag_helpers.diff (2.7 kB) - added by thechrisoshow on 02/27/08 15:20:39.
Tests for RecordTagHelper methods

Change History

02/26/08 20:39:46 changed by thechrisoshow

Patch updated to use assert_dom_equals

02/26/08 21:03:17 changed by Catfish

More tests = more better +1

02/26/08 21:33:45 changed by jamesh

I like your idea, but I think you might want to expand on it more. You're just kind of checking basic output expectations. How about testing that convolution of *args processing to see if the prefix works? How about a test to make sure that class names are correctly inserted into the <div*gt; tag?

02/26/08 22:32:00 changed by thechrisoshow

Added a couple of additional tests

02/26/08 22:36:07 changed by jamesh

Excellent work. +1

02/27/08 15:20:39 changed by thechrisoshow

  • attachment tests_for_record_tag_helpers.diff added.

Tests for RecordTagHelper methods

02/27/08 15:21:13 changed by thechrisoshow

Added an extra test for testing blocks (and consequently tidied up the other tests)

02/27/08 15:24:42 changed by h-lame

  • keywords set to tests verified.

+1 Those extra tests you just added really sweeten the deal

03/05/08 01:26:27 changed by pratik

  • status changed from new to closed.
  • resolution set to fixed.

(In [8980]) Tests for div_for and content_tag_for helpers. Closes #11223 [thechrisoshow]