Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11061 (new enhancement)

Opened 8 months ago

Last modified 8 months ago

[PATCH] Changing construct_calculation_sql to use quoted_table_name

Reported by: pat Assigned to: core
Priority: normal Milestone: 2.x
Component: ActiveRecord Version: edge
Severity: minor Keywords: tiny
Cc:

Description

Current code in construct_calculation_sql uses connection.quote_table_name(table_name), instead of quoted_table_name - I'm thinking the latter is cleaner, and if you've got the helper method, you may as well use it where possible.

Couldn't spot any other places where it could be used but wasn't.

Patch attached.

Attachments

quoting_table_name_in_calculations.diff (1.2 kB) - added by pat on 02/09/08 03:29:00.
Patch to use quoted_table_name in construct_calculation_sql

Change History

02/09/08 03:29:00 changed by pat

  • attachment quoting_table_name_in_calculations.diff added.

Patch to use quoted_table_name in construct_calculation_sql

02/09/08 03:29:26 changed by pat

  • type changed from defect to enhancement.

02/09/08 10:41:18 changed by kampers

  • keywords changed from quoted table name to tiny.
  • summary changed from [PATCH][TINY] Changing construct_calculation_sql to use quoted_table_name to [PATCH] Changing construct_calculation_sql to use quoted_table_name.

+1. Applies clean, looks good, tests pass (used mysql and sqlite3).