Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #11034 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

[PATCH] Add a uses_tzinfo test helper, to avoid failing tests

Reported by: mpalmer Assigned to: core
Priority: normal Milestone: 2.x
Component: ActiveRecord Version: edge
Severity: normal Keywords: ci test patch
Cc:

Description

r8806 introduced some new timezone handling code, the tests for which rely on the presence of tzinfo gem, and which get rather shirty if it isn't there.

The attached patch fixes these failing tests by providing a uses_tzinfo shell method, which works almost identically to the uses_mocha method already available.

This fixes CI failures, so I think it's pretty high priority.

Attachments

avoid_failing_tests_without_tzinfo_gem.patch (7.4 kB) - added by mpalmer on 02/06/08 21:58:33.

Change History

02/06/08 21:58:33 changed by mpalmer

  • attachment avoid_failing_tests_without_tzinfo_gem.patch added.

02/06/08 22:26:50 changed by nzkoz

  • status changed from new to closed.
  • resolution set to fixed.

(In [8808]) Add uses_tzinfo to active record tests to prevent breaking the cc.rb build etc. Closes #11034 [mpalmer]