Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #10976 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

[PATCH] ActiveRecord::RecordInvalid not included in documentation

Reported by: gerrit Assigned to: core
Priority: normal Milestone: 2.x
Component: ActiveRecord Version: edge
Severity: normal Keywords: docs tiny verified
Cc:

Description

validations.rb, l. 9:

class RecordInvalid < ActiveRecordError #:nodoc:

should, imho, read

class RecordInvalid < ActiveRecordError

Attachments

remove_nodoc_from_record_invalid_error.diff (0.8 kB) - added by kampers on 02/09/08 11:45:48.
tastes great with trunk and 2-0-stable

Change History

02/02/08 18:31:28 changed by blj

+1

02/02/08 18:42:17 changed by blj

Should there be a patch for this small thing?

02/08/08 23:57:36 changed by lotswholetime

+1

02/09/08 11:44:51 changed by kampers

  • keywords set to docs tiny verified.
  • summary changed from ActiveRecord::RecordInvalid not included in documentation to [PATCH] ActiveRecord::RecordInvalid not included in documentation.

I'd think that a nice patch makes life easier for the core team. Throwing in a monospacing fix, too.

It was probably this way because AR top-level classes show up in the rdoc class list, which is not necessarily desirable, I suppose. But all the other error classes are already rdoc'd, and it needs to be documented somewhere. Makes sense.

+1

02/09/08 11:45:48 changed by kampers

  • attachment remove_nodoc_from_record_invalid_error.diff added.

tastes great with trunk and 2-0-stable

02/10/08 02:49:14 changed by nzkoz

(In [8845]) Show RecordInvalid in the documentation. References #10976 [kampers]

02/10/08 02:50:15 changed by nzkoz

  • status changed from new to closed.
  • resolution set to fixed.

(In [8846]) 2-0-stable: Show RecordInvalid in the documentation. Closes #10976 [kampers]

Merging [8845]