Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #10966 (closed enhancement: fixed)

Opened 3 months ago

Last modified 1 week ago

[PATCH] [TEST] Require Prototype 1.6.0.x in version check, prevent single load limitation

Reported by: staaky Assigned to: madrobby
Priority: normal Milestone: 2.x
Component: script.aculo.us Version: edge
Severity: normal Keywords: version check load
Cc:

Description

I updated the version check so that it is not limited to x.x.x but can check for any version. This will allow to require Prototype 1.6.0.x, instead of just 1.6.0.

It could be worth having especially to inform those using incompatible versions of Prototype/Scriptaculous.

I also changed the loader so it will never clash with scripts using the same loader mechanism, closes #9032

Attachments

improved_versioncheck_noloaderclashing.diff (2.5 kB) - added by staaky on 02/04/08 15:22:08.

Change History

01/31/08 14:56:34 changed by staaky

  • type changed from defect to enhancement.
  • summary changed from [PATCH] Require Prototype 1.6.0.x in version check, prevent single load limitation to [PATCH] [TEST] Require Prototype 1.6.0.x in version check, prevent single load limitation.

Created test-page and updated the patch.

01/31/08 15:28:17 changed by Tobie

I'd rather see a build version number in Prototype based on the svn changeset number.

01/31/08 15:44:20 changed by staaky

That's a great idea. It would be much cleaner, but requires Prototype to have something like Prototype.Revision, thoughts?

02/04/08 15:22:08 changed by staaky

  • attachment improved_versioncheck_noloaderclashing.diff added.

02/04/08 15:26:27 changed by staaky

Updated versioncheck patch and tests based on Mislavs suggestion.

05/05/08 23:21:55 changed by staaky

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in git