Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #10766 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

Update ActionMailer to TMail 1.2.1

Reported by: mikel Assigned to: nzkoz
Priority: normal Milestone: 2.1
Component: ActionMailer Version: edge
Severity: normal Keywords: TMail
Cc:

Description

TMail 1.2.1 is out (or will be in 24 hours).

I have updated ActionMailer to the new version of TMail.

Also, fixed a test in mail_service_test.rb => test_decode_encoded_attachment_filename which had an incorrect decode value and the test was passing even though the code was wrong. This showed up when I fixed another part of TMail, and then this test broke.

See test output following for what it was expecting and what it received. The test result SHOULD give spaces in the file name. Changed the test to reflect this and all tests pass.

  1) Failure:
test_decode_encoded_attachment_filename(ActionMailerTest)
    [./test/mail_service_test.rb:841:in `test_decode_encoded_attachment_filename'
   <snip>
<"01QuienTeDijat.Pitbull.mp3"> expected but was
<"01 Quien Te Dij\212at. Pitbull.mp3">.

The TMail Fixes are:

* More documentation

* Added 15 test cases from the Rails ActionMailer to TMail

* Changed mailscanner to tmailscanner (mailscanner is copyrighted)

* Closed TMail Bug - Handled quote boundary being gready on content-type header (M. Mondragon)

* Closed TMail 16025 - Fixed scanner.rb so it passes same tests as scanner.c

* Closed TMail 16283 - Handled incorrect decoding of attachments (M. Aoki - garyo)

* Closed TMail 16899 - HeaderField.new_from_port and added test cases to cover this code

* Closed TMail 16900 - UNIXMbox.fromaddr missing port param and does not return Envelope Sender

Attachments

action_mailer_to_TMail_1-2-1.diff (239.0 kB) - added by mikel on 01/11/08 00:54:13.
Updates ActionMailer to TMail version 1.2.1

Change History

01/11/08 00:54:13 changed by mikel

  • attachment action_mailer_to_TMail_1-2-1.diff added.

Updates ActionMailer to TMail version 1.2.1

01/11/08 01:06:38 changed by bitsweat

  • keywords changed from TMail ActionMailer to TMail.
  • milestone changed from 2.x to 2.1.

Is TMail compatible with Ruby 1.9 yet? It's one of the dependencies holding up Rails' Ruby 1.9 compatibility.

01/11/08 01:08:08 changed by bitsweat

Also, small request -- please don't update the changelog.

01/11/08 02:00:36 changed by mikel

bitsweat: On the 1.9 compatibility - not yet. I have a couple of bugs on the TMail Rubyforge to get handled. Have to get 1.9 installed and try it out.

Got it on the log.

01/11/08 02:02:36 changed by bitsweat

  • status changed from new to closed.
  • resolution set to fixed.

[8620] trunk and [8621] 2-0-stable

01/11/08 02:11:50 changed by bitsweat

(In [8622]) Reorder changelog. References #10766.

01/11/08 02:17:05 changed by bitsweat

(In [8623]) Merge [8622] to stable. References #10766.