Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #10714 (new defect)

Opened 4 months ago

Last modified 4 months ago

[PATCH] Scriptaculous_slider plugin: Update to script.aculo.us 1.8.1, fix init.rb and array_or_numeric_for_javascript

Reported by: dtsato Assigned to: core
Priority: normal Milestone: 2.x
Component: Plugins Version: edge
Severity: normal Keywords: scriptaculous_slider plugin
Cc:

Description

This patch updates slider.js as of script.aculo.us 1.8.1 as well as fixes the following bugs:

  • the plugin was not being loaded due to init.rb not including slider_helper properly (should not use ActionView::Base::load_helpers)
  • private method ActionView::Helpers::SliderHelper#array_or_numeric_for_javascript should not join numeric arrays with single quotes
  • removes duplicated methods from ActionView::Helpers::JavaScriptHelper#array_or_string_for_javascript and ActionView::Helpers::JavaScriptHelper#options_for_javascript

Attachments

update_to_1_8_1_fix_init_and_numeric_array_for_javascript.diff (13.1 kB) - added by dtsato on 01/06/08 06:00:46.

Change History

01/06/08 06:00:46 changed by dtsato

  • attachment update_to_1_8_1_fix_init_and_numeric_array_for_javascript.diff added.

01/06/08 06:06:11 changed by dtsato

  • keywords set to scriptaculous_slider plugin.