[PATCH][TINY] (Ruby 1.9 compat) fix raise call and constant name resolution in Duration

Needs to a test case demonstrating it on 1.9.

Sure, there's an interesting gotcha for assert_raise here to show it does not work in 1.9.

It turns out that dependencies.rb is triggered and raises, well, ArgumentError :-). So the obvious test does not depict the problem. I'll figure out a way to make the test fail with the original code, and pass with the fix.

OK, I've finally resorted to test the message. It is a little unusual so I've explained the intention in the assertion message. The patch has been updated.

Re-assigning to bitsweat (he said to assign 1.9 compatibility-related tickets to him).

As I mentioned on #rails-contrib, if you could swap the order of the 1st 2 arguments to assert_equal here:

assert_equal e.message, 'expected a time or date, got ""', "ensure ArgumentError is not being raised by dependencies.rb" 

so that the failure message is not confusing, that'd be great.

Absolutely, a new patch has been attached.

+1 Thanks!

How about having Duration inherit ActiveSupport::BasicObject instead, and adding support for raise?

Hmm, I see there is some controversy regarding AS::BasicObject, actually ;)

In fact it does already inherit from AS::BasicObject because the bare constant BasicObject is evaluated inside module ActiveSupport:

  $ ~/ruby-1.9.0/bin/irb
  irb(main):001:0> RUBY_VERSION
  => "1.9.0"
  irb(main):002:0> require "./active_support.rb"
  => true
  irb(main):003:0> ActiveSupport::Duration.superclass
  => ActiveSupport::BasicObject

I have not enough perspective to have an opinion about adding raise in AS::BasicObject, but sounds fine in the sense that it is OK for me not to be able to puts from a BasicObject, but being able to raise an exception is another issue. I'll write a patch in a minute.

Done!

(In [8523]) Ruby 1.9 compat: add #raise to AS::BasicObject, fixup Duration argument error. Closes #10594.