[PATCH] Add query methods to RAILS_ENV

I love this!

+1

I love it too.

Shouldn't this check for the available files under config/environments? Some people use more than the default ones and it'd be nice for them to have RAILS_ENV.staging?

I considered looking for files, but I thought this might be good enough for 95% of the time. I'm open to changing it though if other people think checking files is a good idea.

I'll plus it if it scans the environment files. I usually have at least an additional qa.rb in there :)

+1 from me. But I'd love it more if it scans the env dir. A lot of my projects are ending up with a staging env.

fair enough, version using files under config/environments done.

+1

+1

Is there meant to be a Kernel#p call on line 10 of test_help.rb? It would be good to eliminate the duplication too, if possible.

Yup agree with turnip.

-1 on the new patch (despite my +1 on the original patch).

If you can move out the duplicated code in railties/lib/test_help.rb that'd be great. I haven't tested it but I don't think you'd have to redefine the methods all over again in the test helper.

Agreed that the duplicated code should be removed, if possible.

Otherwise, +1. I like it!

Okay, new version.. No dup code, I followed the pattern introduced by ruby_version_check and just put the dup code in a file.

Also, it still scans the file system to get the environments.

Just in case, +1 ;)

cool, +1 :)

+1

+1

Definitely a great idea and I'm glad someone finally submitted a patch for this.

+1 good idea. I'm just wondering if using RAILS_ENV.development? is better than using Environment.development?

Any thoughts?

+1

I definitely like RAILS_ENV.development? better than RAILS_ENV == "development". However, I think using either one in code is generally a bad idea. Instead of checking to see if RAILS_ENV is development, I'd prefer some sort of meaningful constant set in development.rb.

Based on the example in the ticket description, I prefer: caches_page :index if CACHE_INDEX_PAGE

This makes it easier to create other environments. Let's say I want an environment called 'dans_development' that is like development, but a little bit different. I could create dans_development.rb, and do: load File.dirname(__FILE__) + "/development.rb", and then make some custom tweaks. With a constant set in development.rb, behavior would remain the same, where with checks for RAILS_ENV.development?, things would change.

Jay, add_query_methods_to_RAILS_ENV.rb is missing from the latest patch. For that reason, I'm removing the verified keyword for now. Please add "verified" back after a new patch is submitted.

Regardless, I like the idea behind this patch.

Updated, sorry I missed that.

Cheers, Jay

+1 Thanks.

+1 usage looks clean

Like the general idea, but not as a hack on a string like RAILS_ENV. Instead, we should take this as an opportunity to come up with a unified class for this:

  Rails.log # => RAILS_LOG
  Rails.environment.development?
  Rails.cache # => RAILS_CACHE

...and so on. We should probably start that as a new ticket. Jay, want to have a go at it?