Ruby on Rails | Screencasts | Download | Documentation | Weblog | Community | Source

Ticket #10515 (closed defect: fixed)

Opened 7 months ago

Last modified 5 months ago

[PATCH] Capistrano Git SCM command path bug + git patch

Reported by: grempe Assigned to: minam
Priority: normal Milestone: 2.x
Component: Capistrano Version: edge
Severity: normal Keywords: verified
Cc: gdolley@ucla.edu

Description

The 'sync' method in the Git SCM did not respect the setting of :scm_command and tried to find the 'git' executable on the remote machine's path. If git was in a non-standard location or not on the remote path an exception would occur. This patch makes the 'sync' method behave consistently with other Git SCM methods in that it will use the :scm_command value to execute the needed git command from the specified location.

e.g. will now remotely execute '/opt/local/bin/git ...' instead of 'git ...' when :scm_command is set to '/opt/local/bin/git'.

Attachments

0001-Bugfix-Git-scm-sync-method-ignored-value-of-scm.patch (2.4 kB) - added by grempe on 12/15/07 23:46:29.

Change History

12/15/07 23:46:29 changed by grempe

  • attachment 0001-Bugfix-Git-scm-sync-method-ignored-value-of-scm.patch added.

12/16/07 00:00:01 changed by garrydolley

Looks good, thanks for adding the test.

+1

12/16/07 00:20:36 changed by topfunky

+1

Good catch.

12/16/07 00:59:50 changed by sjgman9

this also looks good. +1

12/16/07 01:02:30 changed by lawrence

  • keywords set to verified.

+1, had same issue

12/17/07 08:48:19 changed by evolving_jerk

+1

01/31/08 04:55:24 changed by minam

  • status changed from new to closed.
  • resolution set to fixed.

(In [8759]) Add test case from #10515 to show that scm_command is honored by the git module. (The rest was implemented as a side-effect of [8755]. closes #10515)