create_table ignores primary_key_prefix_type

patch file vs 1.2.6

2.0 RC2 has no changes that should intersect this patch.

Thanks for contributing, but this needs unit tests. Don't worry, it should also be simple. First checkout the Rails trunk with SVN and set up a database or two for testing. Then create a unit test for wanted behavior that fails without your fixes. Generate the patch for both tests and fixes by using svn diff.

As stated in the description of report {68}, the 2.0 milestone should only be used by core members for real show stoppers.

This fixes the create_table with primary_key_prefix problems. (Also includes a couple of tests)

+1

Now patches cleanly against trunk

(In [9056]) Migrations: create_table supports primary_key_prefix_type. Closes #10314.

(In [9057]) Merge [9056] from trunk: Migrations: create_table supports primary_key_prefix_type. References #10314.

I have installed http://svn.rubyonrails.org/rails/branches/2-0-stable (r9125) into ventor/rails as an external. This is supposed to have this issue fixed per CS9057, however, given this config/environment.rb:

# Use table_id instead of id for primary key. config.active_record.primary_key_prefix_type = 'table_name_with_underscore'

and running rake db:drop; rake db:migrate with this migration:

class CreateEntities < ActiveRecord::Migration

def self.up

create_table :entities do |t|

t.string :entity_name, :null => false,

:limit => 40

t.string :entity_legal_name, :null => false,

:limit => 120

t.string :entity_legal_form, :null => false,

:limit => 4

t.timestamps

end

I get this sqlite3 schema as a result:

sqlite> .schema entities CREATE TABLE entities ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "entity_name" varchar(40) NOT NULL, "entity_legal_name" varchar(120) NOT NULL, "entity_legal_form" varchar(4) NOT NULL, "created_at" datetime DEFAULT NULL, "updated_at" datetime DEFAULT NULL);

I have confirmed that I am using the correct rails through the simple expedient of removing the rails gem. My application enviromnet is given below:

Ruby version 1.8.5 (i386-linux) RubyGems version 1.1.0 Rails version 2.0.2 Active Record version 2.0.2 Action Pack version 2.0.2 Active Resource version 2.0.2 Action Mailer version 2.0.2 Active Support version 2.0.2 Edge Rails revision 9243 Application root /home/byrnejb/Software/Development/Projects/proforma Environment development Database adapter sqlite3 Database schema version 41

Ah. This fix requires that the argument to:

config.active_record.primary_key_prefix_type =

must be a symbol. A string value fails. Is this intentional?

It matches AWDwR.