Changeset 9247

Timestamp:

04/10/08 13:48:43 (3 months ago)

Author:

pratik

Message:

Ensure that save on child object fails for invalid belongs_to association. Closes #11555. [rubyruy]

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/associations.rb (modified) (1 diff)
• trunk/activerecord/test/cases/associations/belongs_to_associations_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Ensure that save on child object fails for invalid belongs_to association. Closes #11555. [rubyruy]
-
-* Add support for interleaving migrations by storing which migrations have run in the new schema_migrations table. Closes #11493 [jordi]

trunk/activerecord/lib/active_record/associations.rb

@@ -923 +923 @@
-        end
-
+        add_single_associated_save_callbacks(reflection.name)
+
-        configure_dependency_for_belongs_to(reflection)
-      end

trunk/activerecord/test/cases/associations/belongs_to_associations_test.rb

@@ -378 +378 @@
-  end
-
+  def test_save_fails_for_invalid_belongs_to
+    log = AuditLog.new
+    assert log.valid?
+
+    log.build_developer # Build invalid association
+    assert !log.developer.valid?
+    assert !log.valid?
+    assert_equal "is invalid", log.errors.on("developer")
+    
+    assert !log.save
+  end
+
-end