Changeset 9243

Timestamp:

04/08/08 05:20:33 (5 months ago)

Author:

rick

Message:

ActiveRecord::Base#sum defaults to 0 if no rows are returned. Closes #11550 [kamal]

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/calculations.rb (modified) (1 diff)
• trunk/activerecord/test/cases/calculations_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* ActiveRecord::Base#sum defaults to 0 if no rows are returned.  Closes #11550 [kamal]
-
-* Ensure that respond_to? considers dynamic finder methods. Closes #11538. [floehopper]

trunk/activerecord/lib/active_record/calculations.rb

@@ -72 +72 @@
-      #   Person.sum('age')
-      def sum(column_name, options = {})
-
+ || 0
-      end
-

trunk/activerecord/test/cases/calculations_test.rb

@@ -96 +96 @@
-  def test_should_sum_field_with_conditions
-    assert_equal 105, Account.sum(:credit_limit, :conditions => 'firm_id = 6')
+  end
+
+  def test_should_return_zero_if_sum_conditions_return_nothing
+    assert_equal 0, Account.sum(:credit_limit, :conditions => '1 = 2')
-  end
-