Changeset 9156

Timestamp:

03/31/08 01:09:39 (5 months ago)

Author:

bitsweat

Message:

Add query methods for superclass_delegating_reader

Files:

• trunk/activesupport/lib/active_support/core_ext/class/delegating_attributes.rb (modified) (1 diff)
• trunk/activesupport/test/core_ext/class/delegating_attributes_test.rb (modified) (3 diffs)

trunk/activesupport/lib/active_support/core_ext/class/delegating_attributes.rb

@@ -20 +20 @@
-        self.class.#{name}
-      end
+      def self.#{name}?
+        !!#{name}
+      end
+      def #{name}?
+        !!#{name}
+      end
-      EOS
-    end

trunk/activesupport/test/core_ext/class/delegating_attributes_test.rb

@@ -26 +26 @@
-    # should be no mutator
-    assert single_class.respond_to?(:only_reader)
+    assert single_class.respond_to?(:only_reader?)
-    assert single_class.public_instance_methods.map(&:to_s).include?("only_reader")
+    assert single_class.public_instance_methods.map(&:to_s).include?("only_reader?")
-    assert !single_class.respond_to?(:only_reader=)
-  end
@@ -52 +54 @@
-  def test_working_with_simple_attributes
-    single_class.superclass_delegating_accessor :both
-
+
+
+
-    assert_equal "HMMM", single_class.both
+    assert_equal true, single_class.both?
+
-    assert_equal "HMMM", single_class.new.both
+    assert_equal true, single_class.new.both?
+
+    single_class.both = false
+    assert_equal false, single_class.both?
-  end
-
@@ -74 +84 @@
-    parent.superclass_delegating_accessor :both
-    child = Class.new(parent)
-
+ 
-    assert_equal "1", child.both
-
-=
+ = 
-    assert_equal "1", parent.both
-    assert_equal "2", child.both
-
-=
+ = 
-    assert_equal "3", parent.both
-    assert_equal "2", child.both