Changeset 9053

Timestamp:

03/17/08 23:45:42 (2 months ago)

Author:

david

Message:

Fixed that polymorphic routes would modify the input array (closes #11363) [thomas.lee]

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_controller/polymorphic_routes.rb (modified) (1 diff)
• trunk/actionpack/test/controller/polymorphic_routes_test.rb (modified) (1 diff)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fixed that polymorphic routes would modify the input array #11363 [thomas.lee]
-
-* Added :format option to NumberHelper#number_to_currency to enable better localization support #11149 [lylo]

trunk/actionpack/lib/action_controller/polymorphic_routes.rb

@@ -69 +69 @@
-    #
-    def polymorphic_url(record_or_hash_or_array, options = {})
+      if record_or_hash_or_array.kind_of?(Array)
+        record_or_hash_or_array = record_or_hash_or_array.dup
+      end
+
-      record    = extract_record(record_or_hash_or_array)
-      format    = (options[:action].to_s == "formatted" and record_or_hash_or_array.pop)

trunk/actionpack/test/controller/polymorphic_routes_test.rb

@@ -126 +126 @@
-    end
-
+    def test_polymorphic_path_does_not_modify_arguments
+      expects(:admin_article_responses_url).with(@article)
+      path = [:admin, @article, @response]
+      assert_no_difference 'path.size' do
+        polymorphic_url(path)
+      end
+    end
-  end
-end