Changeset 9020

Timestamp:

03/13/08 03:22:25 (7 months ago)

Author:

rick

Message:

Fix more obscure nested parameter hash parsing bug. Closes #10797 [thomas.lee]

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_controller/request.rb (modified) (1 diff)
• trunk/actionpack/test/controller/request_test.rb (modified) (1 diff)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fix more obscure nested parameter hash parsing bug.  #10797 [thomas.lee]
-
-* Added ActionView::Helpers::register_javascript/stylesheet_expansion to make it easier for plugin developers to inject multiple assets #10350 [lotswholetime]

trunk/actionpack/lib/action_controller/request.rb

@@ -683 +683 @@
-          key = CGI.unescape(key)
-          parent << (@top = {}) if top.key?(key) && parent.is_a?(Array)
-
+
+
-        else
-          raise ArgumentError, "Don't know what to do: top is #{top.inspect}"

trunk/actionpack/test/controller/request_test.rb

@@ -712 +712 @@
-    assert_equal expected, ActionController::AbstractRequest.parse_request_parameters(input)
-  end
+
+  def test_parse_params_with_complex_nesting
+    input = { "a[][b][c][][d][]" => %w(e) }
+    expected = {"a" => [{"b" => {"c" => [{"d" => ["e"]}]}}]}
+    assert_equal expected, ActionController::AbstractRequest.parse_request_parameters(input)
+  end
-end
-