Changeset 9018

Timestamp:

03/13/08 03:06:51 (6 months ago)

Author:

rick

Message:

Ensure that ActiveRecord::Calculations disambiguates field names with the table name. Closes #11027 [cavalle]

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/calculations.rb (modified) (1 diff)
• trunk/activerecord/test/cases/associations/join_model_test.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Ensure that ActiveRecord::Calculations disambiguates field names with the table name.  #11027 [cavalle]
-
-* Added add/remove_timestamps to the schema statements for adding the created_at/updated_at columns on existing tables #11129 [jramirez]

trunk/activerecord/lib/active_record/calculations.rb

@@ -156 +156 @@
-          merged_includes = merge_includes(scope ? scope[:include] : [], options[:include])
-          aggregate_alias = column_alias_for(operation, column_name)
+          column_name     = "#{connection.quote_table_name(table_name)}.#{column_name}" unless column_name == "*" || column_name.to_s.include?('.')
-
-          if operation == 'count'

trunk/activerecord/test/cases/associations/join_model_test.rb

@@ -545 +545 @@
-  end
-
+  def test_calculations_on_has_many_through_should_disambiguate_fields
+    assert_nothing_raised { authors(:david).categories.maximum(:id) }
+  end
+  
+  def test_calculations_on_has_many_through_should_not_disambiguate_fields_unless_necessary
+    assert_nothing_raised { authors(:david).categories.maximum("categories.id") }
+  end
+
-  def test_has_many_through_has_many_with_sti
-    assert_equal [comments(:does_it_hurt)], authors(:david).special_post_comments