Changeset 9014

Timestamp:

03/13/08 02:17:04 (2 months ago)

Author:

david

Message:

Added add/remove_timestamps to the schema statements for adding the created_at/updated_at columns on existing tables (closes #11129) [jramirez]

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb (modified) (1 diff)
• trunk/activerecord/test/cases/active_schema_test_mysql.rb (modified) (1 diff)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Added add/remove_timestamps to the schema statements for adding the created_at/updated_at columns on existing tables #11129 [jramirez]
-
-* Added ActiveRecord::Base.find(:last) #11338 [miloops]

trunk/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb

@@ -299 +299 @@
-      end
-
+      # Adds timestamps (created_at and updated_at) columns to the named table.
+      # ===== Examples
+      #  add_timestamps(:suppliers)
+      def add_timestamps(table_name)
+        add_column table_name, :created_at, :datetime
+        add_column table_name, :updated_at, :datetime    
+      end
+      
+      # Removes the timestamp columns (created_at and updated_at) from the table definition.
+      # ===== Examples
+      #  remove_timestamps(:suppliers)
+      def remove_timestamps(table_name)
+        remove_column table_name, :updated_at   
+        remove_column table_name, :created_at       
+      end
+      
-      protected
-        def options_include_default?(options)

trunk/activerecord/test/cases/active_schema_test_mysql.rb

@@ -40 +40 @@
-  end
-
+  def test_add_timestamps 
+    #we need to actually modify some data, so we make execute to point to the original method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute_with_stub, :execute
+      alias_method :execute, :execute_without_stub
+    end  
+    ActiveRecord::Base.connection.create_table :delete_me do |t|        
+    end
+    ActiveRecord::Base.connection.add_timestamps :delete_me
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='updated_at' AND TYPE='datetime'").num_rows, 1
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='created_at' AND TYPE='datetime'").num_rows, 1
+  ensure    
+    ActiveRecord::Base.connection.drop_table :delete_me rescue nil  
+    #before finishing, we restore the alias to the mock-up method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute, :execute_with_stub
+    end
+  end
+  
+  def test_remove_timestamps 
+    #we need to actually modify some data, so we make execute to point to the original method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute_with_stub, :execute
+      alias_method :execute, :execute_without_stub
+    end  
+    ActiveRecord::Base.connection.create_table :delete_me do |t|        
+      t.timestamps
+    end
+    ActiveRecord::Base.connection.remove_timestamps :delete_me
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='updated_at' AND TYPE='datetime'").num_rows, 0
+    assert_equal ActiveRecord::Base.connection.execute("SHOW FIELDS FROM delete_me where FIELD='created_at' AND TYPE='datetime'").num_rows, 0
+  ensure    
+    ActiveRecord::Base.connection.drop_table :delete_me rescue nil  
+    #before finishing, we restore the alias to the mock-up method
+    ActiveRecord::ConnectionAdapters::MysqlAdapter.class_eval do      
+      alias_method :execute, :execute_with_stub
+    end
+  end
+
+
-  private
-    def method_missing(method_symbol, *arguments)