Changeset 9013

Timestamp:

03/13/08 01:54:34 (1 year ago)

Author:

david

Message:

Fixed that BufferedLogger should create its own directory if one doesnt already exist (closes #11285) [lotswholetime]

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/buffered_logger.rb (modified) (1 diff)
• trunk/activesupport/test/buffered_logger_test.rb (modified) (1 diff)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fixed that BufferedLogger should create its own directory if one doesn't already exist #11285 [lotswholetime]
-
-* Fix Numeric time tests broken by DST change by anchoring them to fixed times instead of Time.now. Anchor TimeZone#now DST test to time specified with Time.at instead of Time.local to work around platform differences with Time.local and DST representation [Geoff Buesing]

trunk/activesupport/lib/active_support/buffered_logger.rb

@@ -48 +48 @@
-        @log.sync = true
-      else
+        FileUtils.mkdir_p(File.dirname(log))
-        @log = open(log, (File::WRONLY | File::APPEND | File::CREAT))
-        @log.sync = true

trunk/activesupport/test/buffered_logger_test.rb

@@ -105 +105 @@
-    assert !@output.string.empty?, @output.string
-  end
+  
+  def test_should_create_the_log_directory_if_it_doesnt_exist
+    tmp_directory = File.join(File.dirname(__FILE__), "tmp")
+    log_file = File.join(tmp_directory, "development.log")
+    assert !File.exist?(tmp_directory)
+    @logger  = ActiveSupport::BufferedLogger.new(log_file)
+    assert File.exist?(tmp_directory)
+  ensure
+    FileUtils.rm_rf(tmp_directory)
+  end
-end