Changeset 8848

Timestamp:

02/10/08 18:20:37 (8 months ago)

Author:

gbuesing

Message:

Pruning unneeded Time#change_time_zone_to_current. Enhanced docs for #change_time_zone

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/time/zones.rb (modified) (2 diffs)
• trunk/activesupport/test/core_ext/time_with_zone_test.rb (modified) (2 diffs)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Pruning unneeded Time#change_time_zone_to_current. Enhanced docs to #change_time_zone to explain the difference between this method and #in_time_zone [Geoff Buesing]
-
-* TimeZone#new method renamed #local; when used with Time.zone, constructor now reads: Time.zone.local() [Geoff Buesing]

trunk/activesupport/lib/active_support/core_ext/time/zones.rb

@@ -43 +43 @@
-        end
-        
-Gives the corresponding
+Returns the simultaneous
-        #
-        # Examples:
@@ -59 +59 @@
-        end
-
-
+s
-        #
-        #   t = Time.utc(2000)            # => Sat Jan 01 00:00:00 UTC 2000
-        #   t.change_time_zone('Alaska')  # => Sat, 01 Jan 2000 00:00:00 AKST -09:00
-        #   t.change_time_zone('Hawaii')  # => Sat, 01 Jan 2000 00:00:00 HST -10:00
+        #
+        # Note the difference between this method and #in_time_zone: #in_time_zone does a calculation to determine
+        # the simultaneous time in the supplied zone, whereas #change_time_zone does no calculation; it just
+        # "dials in" a new time zone for +self+
-        def change_time_zone(zone)
-          ActiveSupport::TimeWithZone.new(nil, get_zone(zone), self)
-        end
-
-        # Replaces the existing zone to Time.zone; leaves time value intact
-        def change_time_zone_to_current
-          ::Time.zone ? change_time_zone(::Time.zone) : self
-        end
-        

trunk/activesupport/test/core_ext/time_with_zone_test.rb

@@ -36 +36 @@
-      silence_warnings do # silence warnings raised by tzinfo gem
-        assert_equal ActiveSupport::TimeWithZone.new(nil, TimeZone['Alaska'], Time.utc(1999, 12, 31, 19)), @twz.change_time_zone('Alaska')
-      end
-    end
-  
-    def test_change_time_zone_to_current
-      Time.use_zone 'Alaska' do
-        assert_equal ActiveSupport::TimeWithZone.new(nil, TimeZone['Alaska'], Time.utc(1999, 12, 31, 19)), @twz.change_time_zone_to_current
-      end
-    end
@@ -210 +204 @@
-    end
-    
-    def test_change_time_zone_to_current
-      Time.use_zone 'Alaska' do
-        assert_equal 'Sat, 01 Jan 2000 00:00:00 AKST -09:00', @t.change_time_zone_to_current.inspect
-        assert_equal 'Sat, 01 Jan 2000 00:00:00 AKST -09:00', @dt.change_time_zone_to_current.inspect
-      end
-      Time.use_zone 'Hawaii' do
-        assert_equal 'Sat, 01 Jan 2000 00:00:00 HST -10:00', @t.change_time_zone_to_current.inspect
-        assert_equal 'Sat, 01 Jan 2000 00:00:00 HST -10:00', @dt.change_time_zone_to_current.inspect
-      end
-      Time.use_zone nil do
-        assert_equal @t, @t.change_time_zone_to_current
-        assert_equal @dt, @dt.change_time_zone_to_current
-      end
-    end
-    
-    def test_use_zone
-      Time.zone = 'Alaska'