Changeset 8800

Timestamp:

02/04/08 23:22:18 (7 months ago)

Author:

tobie

Message:

prototype: Avoid breaking Element.prototype in browsers which support it. Closes #11004.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/dom.js (modified) (1 diff)
• spinoffs/prototype/trunk/test/unit/dom.html (modified) (2 diffs)

spinoffs/prototype/trunk/CHANGELOG

@@ +1 @@
+* Avoid breaking Element.prototype in browsers which support it. Closes #11004. [cfis, Tobie Langel]
+
-* Prevent Element#cumulativeOffset, Element#getOffsetParent, Element#positionedOffset, Element#viewportOffset and Element#clonePosition from throwing an error in IE when called on a parent-less element. Closes #9416, #10192, #10248. [ronstoney, psiborg, kangax]
-

spinoffs/prototype/trunk/src/dom.js

@@ -58 +58 @@
-  };
-  Object.extend(this.Element, element || { });
+  if (element) this.Element.prototype = element.prototype;
-}).call(window);
-

spinoffs/prototype/trunk/test/unit/dom.html

@@ -5 +5 @@
-  <title>Prototype Unit test file</title>
-  <meta http-equiv="content-type" content="text/html; charset=utf-8" />
+  <script type="text/javascript" charset="utf-8">
+    var originalElement = Element;
+  </script>
-  <script src="../../dist/prototype.js" type="text/javascript"></script>
-  <script src="../lib/unittest.js" type="text/javascript"></script>
@@ -1444 +1447 @@
-      if (Prototype.Browser.IE)
-        assertMatch(/name=["']?my_input_field["']?/, $('my_input_field').outerHTML);
+      
+      if (originalElement && Prototype.BrowserFeatures.ElementExtensions) {
+        Element.prototype.fooBar = Prototype.emptyFunction
+        assertRespondsTo('fooBar', new Element('div'));
+      }
-    }},
-