Changeset 8798

Timestamp:

02/03/08 21:08:13 (7 months ago)

Author:

tobie

Message:

prototype: Prevent Enumerable#eachSlice from entering into an endless loop if passed an argument smaller than 1. Closes #10665.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/enumerable.js (modified) (1 diff)
• spinoffs/prototype/trunk/test/unit/enumerable.html (modified) (1 diff)

spinoffs/prototype/trunk/CHANGELOG

@@ +1 @@
+* Prevent Enumerable#eachSlice from entering into an endless loop if passed an argument smaller than 1. Closes #10665. [kangax, Tobie Langel]
+
-* Allow Selector to correctly detect the presence of namespaced attributes. Closes #10987. [Samuel Lebeau, Tobie Langel]
-

spinoffs/prototype/trunk/src/enumerable.js

@@ -18 +18 @@
-    iterator = iterator ? iterator.bind(context) : Prototype.K;
-    var index = -number, slices = [], array = this.toArray();
+    if (number < 1) return array;
-    while ((index += number) < array.length)
-      slices.push(array.slice(index, index+number));

spinoffs/prototype/trunk/test/unit/enumerable.html

@@ -165 +165 @@
-        Fixtures.Primes.eachSlice( 3, function(slice){ return slice.reverse() }).flatten()
-      );
+      assertEnumEqual(Fixtures.Basic, Fixtures.Basic.eachSlice(-10));
+      assertEnumEqual(Fixtures.Basic, Fixtures.Basic.eachSlice(0));
+      assertNotIdentical(Fixtures.Basic, Fixtures.Basic.eachSlice(0));
-    }},
-