Changeset 8722

Timestamp:

01/25/08 18:54:22 (9 months ago)

Author:

andrew

Message:

Roll back the fix for #9609, since it does not work in Opera. Instead, avoid using "valueOf" or "toString" as field names in forms.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/form.js (modified) (1 diff)
• spinoffs/prototype/trunk/test/unit/form.html (modified) (2 diffs)

spinoffs/prototype/trunk/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Roll back the fix for #9609, since it does not work in Opera. Instead, avoid using "valueOf" or "toString" as field names in forms.
-
-* Prevent DOM node expandos _countedByPrototype and _prototypeEventID from being serialized into (inner|outer)HTML in IE. Closes #10909. [dcpedit, Tobie Langel, Andrew Dupont]

spinoffs/prototype/trunk/src/form.js

@@ -15 +15 @@
-        if (value != null && (element.type != 'submit' || (!submitted &&
-            submit !== false && (!submit || key == submit) && (submitted = true)))) { 
- && !Object.isFunction(result[key])
+
-            // a key is already present; construct an array of values
-            if (!Object.isArray(result[key])) result[key] = [result[key]];

spinoffs/prototype/trunk/test/unit/form.html

@@ -126 +126 @@
-    </form>
-    
-    <form id="trouble_form">
-        <input type="text" name="length" value="foo" />
-        <input type="text" name="toString" value="55" />
-        <input type="text" name="valueOf" value="bar" />
-    </form>
-  </div>
-
@@ -408 +403 @@
-                      $('form').serialize({ submit: 'inexistent' }));
-                      
-      // try to serialize form containing toString, valueOf and length -named elements
-      assertHashEqual({ length: 'foo', toString: 55, valueOf: 'bar' },
-                      $('trouble_form').serialize(true));
-    }},
-