Changeset 8712

Timestamp:

01/24/08 01:33:28 (8 months ago)

Author:

tobie

Message:

prototype: Make Object.isArray correctly identify arrays created in another frame. Closes #10374.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/base.js (modified) (1 diff)
• spinoffs/prototype/trunk/test/unit/base.html (modified) (2 diffs)

spinoffs/prototype/trunk/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Make Object.isArray correctly identify arrays created in another frame. Closes #10374. [pointy, Dean Edwards, Andrew Dupont, Tobie Langel]
-
-* Fixed issue where Element#match failed on attribute selectors with single or double quotes. Closes #10067. [Cezary Okupski, Andrew Dupont]

spinoffs/prototype/trunk/src/base.js

@@ -133 +133 @@
-  
-  isArray: function(object) {
-
+
+
-  },
-  

spinoffs/prototype/trunk/test/unit/base.html

@@ -23 +23 @@
-<!-- Log output -->
-<div id="testlog"> </div>
-
+
+
+
+
+
+
-<!-- Tests follow -->
-<script type="text/javascript" language="javascript" charset="utf-8">
@@ -312 +317 @@
-      assert(Object.isArray([0, 1]));
-      assert(!Object.isArray({}));
+      assert(!Object.isArray($('list').childNodes));
+      assert(!Object.isArray());
+      assert(!Object.isArray(''));
+      assert(!Object.isArray('foo'));
+      assert(!Object.isArray(0));
+      assert(!Object.isArray(1));
+      assert(!Object.isArray(null));
+      assert(!Object.isArray(true));
+      assert(!Object.isArray(false));
+      assert(!Object.isArray(undefined));
-    }},
-