Changeset 8647

Timestamp:

01/16/08 03:54:15 (4 months ago)

Author:

nzkoz

Message:

Don't ignore :precision and :scale when adding columns on postgresql. Closes #6868 [w.piekutowski]

Files:

• trunk/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb (modified) (2 diffs)
• trunk/activerecord/test/migration_test.rb (modified) (1 diff)

trunk/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb

@@ -588 +588 @@
-      end
-
-
+
+
-      def add_column(table_name, column_name, type, options = {})
-        default = options[:default]
@@ -594 +595 @@
-
-        # Add the column.
-_column_name(column_name)} #{type_to_sql(type, options[:limit
+d_column_name} #{type_to_sql(type, options[:limit], options[:precision], options[:scale
-
-        change_column_default(table_name, column_name, default) if options_include_default?(options)

trunk/activerecord/test/migration_test.rb

@@ -269 +269 @@
-    end
-
+    def test_add_column_with_precision_and_scale
+      Person.connection.add_column 'people', 'wealth', :decimal, :precision => 9, :scale => 7
+      Person.reset_column_information
+
+      wealth_column = Person.columns_hash['wealth']
+      assert_equal 9, wealth_column.precision
+      assert_equal 7, wealth_column.scale
+    end
+    
-    def test_native_types
-      Person.delete_all