Changeset 8635

Timestamp:

01/12/08 20:44:31 (8 months ago)

Author:

gbuesing

Message:

Refactor number-to-HH:MM-string conversion logic from TimeZone#formatted_offset to reusable Numeric#to_utc_offset_s method

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/numeric.rb (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/numeric/conversions.rb (added)
• trunk/activesupport/lib/active_support/values/time_zone.rb (modified) (1 diff)
• trunk/activesupport/test/core_ext/numeric_ext_test.rb (modified) (1 diff)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Refactor number-to-HH:MM-string conversion logic from TimeZone#formatted_offset to a reusable Numeric#to_utc_offset_s method. [Geoff Buesing]
-
-* Continue evolution toward ActiveSupport::TestCase.  #10679 [Josh Peek]

trunk/activesupport/lib/active_support/core_ext/numeric.rb

@@ -1 +1 @@
-require 'active_support/core_ext/numeric/time'
-require 'active_support/core_ext/numeric/bytes'
+require 'active_support/core_ext/numeric/conversions'
-
-class Numeric #:nodoc:
-  include ActiveSupport::CoreExtensions::Numeric::Time 
-
+
+
-end

trunk/activesupport/lib/active_support/values/time_zone.rb

@@ -27 +27 @@
-  def formatted_offset( colon=true )
-    return "" if utc_offset == 0
-
-
-
-
+
-  end
-

trunk/activesupport/test/core_ext/numeric_ext_test.rb

@@ -146 +146 @@
-  end
-end
+
+class NumericExtConversionsTest < Test::Unit::TestCase
+  
+  def test_to_utc_offset_s_with_colon
+    assert_equal "-06:00", -21_600.to_utc_offset_s
+    assert_equal "+00:00", 0.to_utc_offset_s
+    assert_equal "+05:00", 18_000.to_utc_offset_s
+  end
+  
+  def test_to_utc_offset_s_without_colon
+    assert_equal "-0600", -21_600.to_utc_offset_s(false)
+    assert_equal "+0000", 0.to_utc_offset_s(false)
+    assert_equal "+0500", 18_000.to_utc_offset_s(false)
+  end
+end