Changeset 8421

Timestamp:

12/16/07 23:50:02 (5 months ago)

Author:

david

Message:

Added option to pass proc to ActionController::Base.asset_host for maximum configurability (closes #10521) [chuyeow]

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_view/helpers/asset_tag_helper.rb (modified) (5 diffs)
• trunk/actionpack/test/template/asset_tag_helper_test.rb (modified) (3 diffs)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*2.0.2* (December 16th, 2007)
+
+* Added option to pass proc to ActionController::Base.asset_host for maximum configurability #10521 [chuyeow]. Example:
+
+    ActionController::Base.asset_host = Proc.new { |source|
+      if source.starts_with?('/images')
+        "http://images.example.com"
+      else
+        "http://assets.example.com"
+      end
+    }
-
-* Fixed that ActionView#file_exists? would be incorrect if @first_render is set #10569 [dbussink]

trunk/actionpack/lib/action_view/helpers/asset_tag_helper.rb

@@ -32 +32 @@
-    #     => <link href="http://assets3.example.com/stylesheets/application.css" media="screen" rel="stylesheet" type="text/css" />
-    #
-four
+4
-    # the wildcard to a single asset host.  You can read more about setting up your DNS CNAME records from
-    # your ISP.
@@ -39 +39 @@
-    # for server load balancing. See http://www.die.net/musings/page_load_time/
-    # for background.
+    #
+    # Alternatively, you can exert more control over the asset host by setting <tt>asset_host</tt> to a proc
+    # that takes a single source argument. This is useful if you are unable to setup 4 actual hosts or have
+    # fewer/more than 4 hosts. The example proc below generates http://assets1.example.com and
+    # http://assets2.example.com randomly.
+    #
+    #   ActionController::Base.asset_host = Proc.new { |source| "http://assets#{rand(2) + 1}.example.com" }
+    #   image_tag("rails.png")
+    #     => <img src="http://assets2.example.com/images/rails.png" alt="Rails" />
+    #   stylesheet_include_tag("application")
+    #     => <link href="http://assets1.example.com/stylesheets/application.css" media="screen" rel="stylesheet" type="text/css" />
+    #
+    # The proc takes a single <tt>source</tt> parameter which is the path of the source asset. This can be used to
+    # generate a particular asset host depending on the asset path.
+    #
+    #    ActionController::Base.asset_host = Proc.new { |source|
+    #      if source.starts_with?('/images')
+    #        "http://images.example.com"
+    #      else
+    #        "http://assets.example.com"
+    #      end
+    #    }
+    #   image_tag("rails.png")
+    #     => <img src="http://images.example.com/images/rails.png" alt="Rails" />
+    #   stylesheet_include_tag("application")
+    #     => <link href="http://assets.example.com/stylesheets/application.css" media="screen" rel="stylesheet" type="text/css" />
-    #
-    # === Using asset timestamps
@@ -386 +412 @@
-        # Prefix with /dir/ if lacking a leading /. Account for relative URL
-        # roots. Rewrite the asset path for cache-busting asset ids. Include
-
-
+
-        def compute_public_path(source, dir, ext = nil, include_host = true)
-          has_request = @controller.respond_to?(:request)
@@ -394 +419 @@
-            if has_request
-              [ @controller.request.protocol,
-
+.to_s
-                @controller.request.relative_url_root,
-                dir, source, ext, include_host ].join
-            else
-
+.to_s
-                dir, source, ext, include_host ].join
-            end
@@ -431 +456 @@
-
-        # Pick an asset host for this source. Returns nil if no host is set,
-
-
+
+
+
-        def compute_asset_host(source)
-          if host = ActionController::Base.asset_host
-
+
+
+
+
+
-          end
-        end

trunk/actionpack/test/template/asset_tag_helper_test.rb

@@ -224 +224 @@
-  end
-
-
-  def test_caching_javascript_include_tag_when_caching_on
-    ENV["RAILS_ASSET_ID"] = ""
@@ -248 +247 @@
-    File.delete(File.join(ActionView::Helpers::AssetTagHelper::JAVASCRIPTS_DIR, 'money.js'))
-  end
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-  def test_caching_javascript_include_tag_when_caching_on_and_using_subdirectory
-    ENV["RAILS_ASSET_ID"] = ""
@@ -305 +321 @@
-    File.delete(File.join(ActionView::Helpers::AssetTagHelper::STYLESHEETS_DIR, 'money.css'))
-  end
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-  def test_caching_stylesheet_include_tag_when_caching_off
-    ENV["RAILS_ASSET_ID"] = ""