Changeset 8332

Timestamp:

12/08/07 00:12:52 (9 months ago)

Author:

rick

Message:

Fix HashWithIndifferentAccess#to_options! so it doesn't clear the options hash. Closes #10419 [ReinH]

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/core_ext/hash/indifferent_access.rb (modified) (1 diff)
• trunk/activesupport/test/core_ext/hash_ext_test.rb (modified) (1 diff)

trunk/activesupport/CHANGELOG

@@ +1 @@
+* Fix HashWithIndifferentAccess#to_options! so it doesn't clear the options hash.  Closes #10419 [ReinH]
+
-*2.0.1* (December 7th, 2007)
-

trunk/activesupport/lib/active_support/core_ext/hash/indifferent_access.rb

@@ -64 +64 @@
-  def stringify_keys!; self end
-  def symbolize_keys!; self end
+  def to_options!; self end
-
-  # Convert to a Hash with String keys.

trunk/activesupport/test/core_ext/hash_ext_test.rb

@@ -205 +205 @@
-    assert_equal 1, h[:first]
-  end
+
+  def test_to_options_on_indifferent_preserves_hash
+    h = HashWithIndifferentAccess.new
+    h['first'] = 1
+    h.to_options!
+    assert_equal 1, h['first']
+  end
+
-
-  def test_indifferent_subhashes