Changeset 7861

Timestamp:

10/13/07 19:05:19 (1 year ago)

Author:

tobie

Message:

Performance improvements to String#times.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/string.js (modified) (1 diff)
• spinoffs/prototype/trunk/test/unit/string.html (modified) (1 diff)

spinoffs/prototype/trunk/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Performance improvements to String#times. [Martin Ström]
-
-* Make Ajax.Response#getHeaderJSON and Ajax.Response#getResponseJSON pseudo private instance methods. [Tobie Langel]

spinoffs/prototype/trunk/src/string.js

@@ -120 +120 @@
-  
-  times: function(count) {
-
-
-
+
-  },
-  

spinoffs/prototype/trunk/test/unit/string.html

@@ -464 +464 @@
-
-    testTimes: function() {with(this) {
+
-      assertEqual('', ''.times(0));
-      assertEqual('', ''.times(5));
+      assertEqual('', 'a'.times(-1));
-      assertEqual('', 'a'.times(0));
-      assertEqual('a', 'a'.times(1));
+      assertEqual('aa', 'a'.times(2));
-      assertEqual('aaaaa', 'a'.times(5));
-      assertEqual('foofoofoofoofoo', 'foo'.times(5));
-      assertEqual('', 'foo'.times(-5));
+      
+      /*window.String.prototype.oldTimes = function(count) {
+        var result = '';
+        for (var i = 0; i < count; i++) result += this;
+        return result;
+      };
+      
+      benchmark(function() {
+        'foo'.times(15);
+      }, 1000, 'new: ');
+      
+      benchmark(function() {
+        'foo'.oldTimes(15);
+      }, 1000, 'previous: ');*/
-    }},
-