Changeset 7823

Timestamp:

10/10/07 05:42:52 (1 year ago)

Author:

nzkoz

Message:

Add deprecation warning for calling .create on has_many associations with an unsaved owner.

Fix regression introduced by [7076] by restoring 1.2.3 behaviour for saving associated records [Bryan Helmkamp]. References #8713

Files:

• branches/1-2-stable/activerecord/lib/active_record/associations.rb (modified) (1 diff)
• branches/1-2-stable/activerecord/lib/active_record/associations/association_collection.rb (modified) (1 diff)
• branches/1-2-stable/activerecord/test/associations_test.rb (modified) (2 diffs)
• branches/1-2-stable/activerecord/test/fixtures/db_definitions/schema.rb (modified) (1 diff)
• branches/1-2-stable/activerecord/test/fixtures/developer.rb (modified) (1 diff)
• branches/1-2-stable/activerecord/test/validations_test.rb (modified) (2 diffs)

branches/1-2-stable/activerecord/lib/active_record/associations.rb

@@ -995 +995 @@
-            association = instance_variable_get("@#{association_name}")
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
-              records_to_save.each { |record| association.send(:insert_record, record) }
-              association.send(:construct_sql)   # reconstruct the SQL queries now that we know the owner's id

branches/1-2-stable/activerecord/lib/active_record/associations/association_collection.rb

@@ -92 +92 @@
-        else
-          record = build(attributes)
-
+
+
+
+
+
-          record
-        end

branches/1-2-stable/activerecord/test/associations_test.rb

@@ -96 +96 @@
-    assert !david.projects.loaded?
-  end
+
+  def test_save_on_parent_saves_children
+    developer = Developer.create :name => "Bryan", :salary => 50_000
+    assert_equal 1, developer.reload.audit_logs.size
+  end
-end
-
@@ -592 +597 @@
-  end
-  
+  def test_regular_create_on_has_many_when_parent_is_new_raises
+    assert_deprecated(/.build instead/) do
+      firm = Firm.new
+      firm.plain_clients.create :name=>"Whoever"
+    end
+  end
+
-  def test_adding_a_mismatch_class
-    assert_raises(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).clients_of_firm << nil }

branches/1-2-stable/activerecord/test/fixtures/db_definitions/schema.rb

@@ -58 +58 @@
-    t.column :custom_lock_version, :integer
-  end
+  
+  create_table :audit_logs, :force => true do |t|
+    t.column :message, :string, :null=>false
+    t.column :developer_id, :integer, :null=>false
+  end
-end

branches/1-2-stable/activerecord/test/fixtures/developer.rb

@@ -32 +32 @@
-  has_and_belongs_to_many :special_projects, :join_table => 'developers_projects', :association_foreign_key => 'project_id'
-
+  has_many :audit_logs
+
-  validates_inclusion_of :salary, :in => 50000..200000
-  validates_length_of    :name, :within => 3..20
+
+  before_create do |developer|
+    developer.audit_logs.build :message => "Computer created"
+  end
+end
+
+class AuditLog < ActiveRecord::Base
+  belongs_to :developer
-end
-

branches/1-2-stable/activerecord/test/validations_test.rb

@@ -632 +632 @@
-    assert !t.save
-    assert t.errors.on(:replies)
-create
+build
-    assert t.valid?
-  end
@@ -837 +837 @@
-      assert !t.save
-      assert t.errors.on(:replies)
-create
+build
-      assert t.valid?
-    end