Changeset 7776

Timestamp:

10/07/07 19:12:02 (1 year ago)

Author:

bitsweat

Message:

Fix url_for, redirect_to, etc. with :controller => :symbol instead of 'string'. Closes #8562, #9525.

Files:

• trunk/actionpack/CHANGELOG (modified) (1 diff)
• trunk/actionpack/lib/action_controller/assertions/response_assertions.rb (modified) (1 diff)
• trunk/actionpack/lib/action_controller/routing.rb (modified) (1 diff)
• trunk/actionpack/test/controller/action_pack_assertions_test.rb (modified) (2 diffs)
• trunk/actionpack/test/controller/url_rewriter_test.rb (modified) (1 diff)

trunk/actionpack/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Fix url_for, redirect_to, etc. with :controller => :symbol instead of 'string'.  #8562, #9525 [Justin Lynn, Tarmo TÀnav, shoe]
-
-* Use #require_library_or_gem to load the memcache library for the MemCache session and fragment cache stores.  Closes #8662. [Rick]

trunk/actionpack/lib/action_controller/assertions/response_assertions.rb

@@ -70 +70 @@
-
-              if value.respond_to?(:[]) && value['controller']
+                value['controller'] = value['controller'].to_s
-                if key == :actual && value['controller'].first != '/' && !value['controller'].include?('/')
-                  new_controller_path = ActionController::Routing.controller_relative_to(value['controller'], @controller.class.controller_path)

trunk/actionpack/lib/action_controller/routing.rb

@@ -1326 +1326 @@
-        expire_on = build_expiry(options, recall)
-
+        if options[:controller]
+          options[:controller] = options[:controller].to_s
+        end
-        # if the controller has changed, make sure it changes relative to the
-        # current controller module, if any. In other words, if we're currently

trunk/actionpack/test/controller/action_pack_assertions_test.rb

@@ -19 +19 @@
-
-  def redirect_to_controller() redirect_to :controller => "elsewhere", :action => "flash_me"; end
+
+  def redirect_to_controller_with_symbol() redirect_to :controller => :elsewhere, :action => :flash_me; end
-
-  def redirect_to_path() redirect_to '/some/path' end
@@ -430 +432 @@
-  end
-
+  def test_assert_redirection_with_symbol
+    process :redirect_to_controller_with_symbol
+    assert_nothing_raised {
+      assert_redirected_to :controller => "elsewhere", :action => "flash_me"
+    }
+    process :redirect_to_controller_with_symbol
+    assert_nothing_raised {
+      assert_redirected_to :controller => :elsewhere, :action => :flash_me
+    }
+  end
+
-  def test_redirected_to_with_nested_controller
-    @controller = Admin::InnerModuleController.new

trunk/actionpack/test/controller/url_rewriter_test.rb

@@ -235 +235 @@
-  end
-
+  def test_path_generation_for_symbol_parameter_keys
+    assert_generates("/image", :controller=> :image)
+  end
+
-  private
-    def extract_params(url)