Changeset 7775

Timestamp:

10/07/07 18:54:36 (1 year ago)

Author:

bitsweat

Message:

Correct BufferedLogger#level? checks. Closes #9806.

Files:

• trunk/activesupport/CHANGELOG (modified) (1 diff)
• trunk/activesupport/lib/active_support/buffered_logger.rb (modified) (1 diff)
• trunk/activesupport/test/buffered_logger_test.rb (modified) (1 diff)

trunk/activesupport/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Correct BufferedLogger#level? checks.  #9806 [wildchild, Johan Sorensen]
-
-* String#to_xs uses Eric Wong's fast_xs extension, if available, for Builder speedup.  http://bogomips.org/fast_xs/  [Jeremy Kemper]

trunk/activesupport/lib/active_support/buffered_logger.rb

@@ -71 +71 @@
-        
-        def #{severity.downcase}?
-@level == #{severity}
+#{severity} >= @level
-        end
-      EOT

trunk/activesupport/test/buffered_logger_test.rb

@@ -86 +86 @@
-    end
-  end
+  
+  def test_should_know_if_its_loglevel_is_below_a_given_level
+    ActiveSupport::BufferedLogger::Severity.constants.each do |level|
+      @logger.level = ActiveSupport::BufferedLogger::Severity.const_get(level) - 1
+      assert @logger.send("#{level.downcase}?"), "didn't know if it was #{level.downcase}? or below"
+    end
+  end
-
-  def test_should_auto_flush_every_n_messages