Changeset 7309

Timestamp:

08/12/07 22:32:19 (11 months ago)

Author:

nzkoz

Message:

Send freshness information when sending Etags. Without this internet explorer will not send conditional gets for a resource, but instead hold on to the responses for the current browser session.

Files:

• trunk/actionpack/lib/action_controller/response.rb (modified) (1 diff)
• trunk/actionpack/test/controller/render_test.rb (modified) (1 diff)

trunk/actionpack/lib/action_controller/response.rb

@@ -47 +47 @@
-        if body.is_a?(String) && (headers['Status'] ? headers['Status'][0..2] == '200' : true)  && !body.empty?
-          self.headers['ETag'] ||= %("#{Digest::MD5.hexdigest(body)}")
-
+, max-age=0, must-revalidate
-
-          if request.headers['HTTP_IF_NONE_MATCH'] == headers['ETag']

trunk/actionpack/test/controller/render_test.rb

@@ -321 +321 @@
-    get :render_hello_world_from_variable
-    assert_equal etag_for("hello david"), @response.headers['ETag']
+    assert_equal "private, max-age=0, must-revalidate", @response.headers['Cache-Control']
-  end
-