Changeset 7308

Timestamp:

08/11/07 19:53:39 (1 year ago)

Author:

sam

Message:

prototype: Make sure Element#observe is always chainable.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/event.js (modified) (1 diff)
• spinoffs/prototype/trunk/test/unit/event.html (modified) (1 diff)

spinoffs/prototype/trunk/CHANGELOG

@@ -1 +1 @@
-*SVN*
-
-stopObserving is
+observe and Element#stopObserving are
-
-* Event.fire/Element#fire now returns the newly-fired event instead of the event's target element.  [sam]

spinoffs/prototype/trunk/src/event.js

@@ -171 +171 @@
-      
-      var wrapper = createWrapper(id, eventName, handler);
-false
+element
-      
-      if (element.addEventListener) {

spinoffs/prototype/trunk/test/unit/event.html

@@ -184 +184 @@
-    }},
-    
-StopObservingIs
+ObserveAndStopObservingAre
-      var span = $("span"), observer = function() { };
-
+
+
-      assertEqual(span, span.stopObserving("somethingHappened", observer));
+
-      span.observe("somethingHappened", observer);
-      assertEqual(span, span.stopObserving("somethingHappened"));
+
-      span.observe("somethingHappened", observer);
-      assertEqual(span, span.stopObserving());
-      assertEqual(span, span.stopObserving()); // assert it again, after there are no observers
+
+      span.observe("somethingHappened", observer);
+      assertEqual(span, span.observe("somethingHappened", observer)); // try to reuse the same observer
+      span.stopObserving();
-    }},
-