Changeset 7238

Timestamp:

07/25/07 03:48:30 (1 year ago)

Author:

rick

Message:

Perform a deep #dup on query cache results so that modifying activerecord attributes does not modify the cached attributes. [Rick]

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/query_cache.rb (modified) (1 diff)
• trunk/activerecord/test/query_cache_test.rb (modified) (2 diffs)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Perform a deep #dup on query cache results so that modifying activerecord attributes does not modify the cached attributes.  [Rick]
-
-# Ensure that has_many :through associations use a count query instead of loading the target when #size is called.  Closes #8800 [lifo]

trunk/activerecord/lib/active_record/query_cache.rb

@@ -59 +59 @@
-          @query_cache[sql] = yield
-        end
-
-
+
+
+
+
+
+
+
+
-      end
-    

trunk/activerecord/test/query_cache_test.rb

@@ -9 +9 @@
-  
-  def test_find_queries
-        
+
-  end
-
-  def test_find_queries_with_cache
-    Task.cache do
-    
+
-    end
-  end
-  
-
+
+
-    Task.cache do
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-    end
-  end
-  
-  def test_query_cache_returned        
-    assert_not_equal ActiveRecord::QueryCache, Task.connection.class
-    Task.cache do 
-      assert_equal ActiveRecord::QueryCache, Task.connection.class      
-    end    
-  end
-  
-
-  def test_cache_is_scoped_on_actual_class_only
-    Task.cache do
-      assert_queries(2) {  Topic.find(1); Topic.find(1) }    
-    end
-  end
-  
-  
-  def test_cache_is_scoped_on_all_descending_classes
-    ActiveRecord::Base.cache do
-    
+
-    end
-  end
@@ -54 +58 @@
-    end
-  end
-    
-  
-end
-
-
-uses_mocha('QueryCacheExpiryTest') do