Changeset 7223

Timestamp:

07/24/07 17:41:27 (1 year ago)

Author:

sam

Message:

prototype: Add Element#identify, which returns the element's ID if it exists, or sets and returns a unique, auto-generated ID (of the form 'anonymous_element_' + auto-incremented digit) otherwise. Use this when you need to ensure an element has an ID. Closes #9012.

Files:

• spinoffs/prototype/trunk/CHANGELOG (modified) (1 diff)
• spinoffs/prototype/trunk/src/dom.js (modified) (3 diffs)
• spinoffs/prototype/trunk/test/unit/dom.html (modified) (2 diffs)

spinoffs/prototype/trunk/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Add Element#identify, which returns the element's ID if it exists, or sets and returns a unique, auto-generated ID (of the form "anonymous_element_" + auto-incremented digit) otherwise.  Use this when you need to ensure an element has an ID.  Closes #9012.  [Jeff Watkins, sam, Tobie Langel]
-
-* Make Element#readAttribute work for cloned elements in IE. Closes #8481. [chem, Tobie Langel]

spinoffs/prototype/trunk/src/dom.js

@@ -232 +232 @@
-    var args = $A(arguments), element = $(args.shift());
-    return Selector.findChildElements(element.parentNode, args).without(element);
+  },
+  
+  identify: function(element) {
+    element = $(element);
+    var id = element.readAttribute('id'), self = arguments.callee;
+    if (id) return id;
+    do { id = 'anonymous_element_' + self.counter++ } while ($(id));
+    element.writeAttribute('id', id);
+    return id;
-  },
-  
@@ -598 +607 @@
-};
-
-getElementsBySelector = Element.Methods.select
+identify.counter = 1
-
-if (!document.getElementsByClassName) document.getElementsByClassName = function(instanceMethods){
@@ -637 +646 @@
-
-Object.extend(Element.Methods, {
+  getElementsBySelector: Element.Methods.select,
-  childElements: Element.Methods.immediateDescendants
-});

spinoffs/prototype/trunk/test/unit/dom.html

@@ -343 +343 @@
-
-<div id="unextended"></div>
+<div id="identification">
+  <div id="predefined_id"></div>
+  <div></div>
+  <div></div>
+  <div></div>
+  <div id="anonymous_element_3"></div>
+</div>
-
-<!-- Tests follow -->
@@ -677 +684 @@
-      });
-    }},
+    
+    testElementIdentify: function() {with(this) {
+      var parent = $('identification');
+      assertEqual(parent.down().identify(), 'predefined_id');
+      assertEqual(parent.down(1).identify(), 'anonymous_element_1');
+      assertEqual(parent.down(2).identify(), 'anonymous_element_2');
+      assertEqual(parent.down(3).identify(), 'anonymous_element_4');
+    }},
-       
-    testElementClassNameMethod: function() {with(this) {