Changeset 7139

Timestamp:

06/27/07 09:25:25 (1 year ago)

Author:

bitsweat

Message:

Generators: look for generators in all gems, not just those suffixed with _generator, in the gem's generators or rails_generators directory. Allow use of the rails_generators directory instead of the standard generators directory in plugins also. Closes #8730.

Files:

• trunk/railties/CHANGELOG (modified) (1 diff)
• trunk/railties/lib/rails_generator/lookup.rb (modified) (4 diffs)
• trunk/railties/lib/rails_generator/scripts.rb (modified) (1 diff)
• trunk/railties/lib/rails_generator/spec.rb (modified) (1 diff)

trunk/railties/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Generators: look for generators in all gems, not just those suffixed with _generator, in the gem's generators or rails_generators directory. Allow use of the rails_generators directory instead of the standard generators directory in plugins also.  #8730 [Dr Nic, topfunky]
-
-* MySQL, PostgreSQL: database.yml defaults to utf-8.  #8701 [matt]

trunk/railties/lib/rails_generator/lookup.rb

@@ -47 +47 @@
-    # A spec is not a generator:  it's a description of where to find
-    # the generator and how to create it.  A source is anything that
-
+Generator
-    module Lookup
-      def self.included(base)
@@ -102 +102 @@
-            sources << PathSource.new(:vendor, "#{::RAILS_ROOT}/vendor/generators")
-            sources << PathSource.new(:plugins, "#{::RAILS_ROOT}/vendor/plugins/*/**/generators")
+            sources << PathSource.new(:plugins, "#{::RAILS_ROOT}/vendor/plugins/*/**/rails_generators")
-          end
-          sources << PathSource.new(:user, "#{Dir.user_home}/.rails/generators")
-
+
+
+
+
-          sources << PathSource.new(:builtin, "#{File.dirname(__FILE__)}/generators/components")
-        end
@@ -186 +190 @@
-    end
-
-
-
-
-
+
-      def initialize
-        super :RubyGems
-      end
-
+
+
+
+
+
-      # Yield latest versions of generator gems.
-      def each
@@ -206 +211 @@
-    end
-
+    # GemPathSource looks for generators within any RubyGem's /rails_generators/<generator_name>_generator.rb file.
+    class GemPathSource < AbstractGemSource
+      # Yield each generator within rails_generator subdirectories.
+      def each
+        generator_full_paths.each do |generator|
+          yield Spec.new(File.basename(generator).sub(/_generator.rb$/, ''), File.dirname(generator), label)
+        end
+      end
+
+      private
+        def generator_full_paths
+          @generator_full_paths ||=
+            Gem::cache.inject({}) do |latest, name_gem|
+              name, gem = name_gem
+              hem = latest[gem.name]
+              latest[gem.name] = gem if hem.nil? or gem.version > hem.version
+              latest
+            end.values.inject([]) do |mem, gem|
+              Dir[gem.full_gem_path + '/{rails_,}generators/**/*_generator.rb'].each do |generator|
+                mem << generator
+              end
+              mem
+            end
+        end
+    end
+
-  end
-end

trunk/railties/lib/rails_generator/scripts.rb

@@ -44 +44 @@
-          def usage_message
-            usage = "\nInstalled Generators\n"
-each do |
+inject({}) do |mem, 
-              label = source.label.to_s.capitalize
-
+
+
+
+
-              usage << "  #{label}: #{names.join(', ')}\n" unless names.empty?
-            end

trunk/railties/lib/rails_generator/spec.rb

@@ -3 +3 @@
-    # A spec knows where a generator was found and how to instantiate it.
-    # Metadata include the generator's name, its base path, and the source
-
+Path
-    class Spec
-      attr_reader :name, :path, :source