Changeset 7133

Timestamp:

06/27/07 02:56:11 (1 year ago)

Author:

bitsweat

Message:

Array attribute conditions work with proxied association collections. Closes #8318.

Files:

• trunk/activerecord/CHANGELOG (modified) (1 diff)
• trunk/activerecord/lib/active_record/base.rb (modified) (1 diff)
• trunk/activerecord/test/finder_test.rb (modified) (2 diffs)

trunk/activerecord/CHANGELOG

@@ -1 +1 @@
-*SVN*
+
+* Array attribute conditions work with proxied association collections.  #8318 [kamal, theamazingrando]
-
-* Fix polymorphic has_one associations declared in an abstract class.  #8638 [lifofifo, daxhuiberts]

trunk/activerecord/lib/active_record/base.rb

@@ -1288 +1288 @@
-          case argument
-            when nil   then "IS ?"
-
+, ActiveRecord::Associations::AssociationCollection
-            when Range then "BETWEEN ? AND ?"
-            else            "= ?"

trunk/activerecord/test/finder_test.rb

@@ -9 +9 @@
-
-class FinderTest < Test::Unit::TestCase
-
+, :authors
-
-  def test_find
@@ -158 +158 @@
-    assert Topic.find(1, :conditions => { :approved => false })
-    assert_raises(ActiveRecord::RecordNotFound) { Topic.find(1, :conditions => { :approved => true }) }
+  end
+
+  def test_find_on_association_proxy_conditions
+    assert_equal [1, 2, 3, 5, 6, 7, 8, 9, 10], Comment.find_all_by_post_id(authors(:david).posts).map(&:id).sort
-  end
-