Changeset 7115

Timestamp:

06/25/07 16:29:26 (1 year ago)

Author:

david

Message:

Throw a InvalidOpenId exception instead of just a RuntimeError when the URL can't be normalized [DHH]

Files:

• plugins/open_id_authentication/CHANGELOG (modified) (1 diff)
• plugins/open_id_authentication/lib/open_id_authentication.rb (modified) (3 diffs)
• plugins/open_id_authentication/test/normalize_test.rb (modified) (2 diffs)

plugins/open_id_authentication/CHANGELOG

@@ +1 @@
+* Throw a InvalidOpenId exception instead of just a RuntimeError when the URL can't be normalized [DHH]
+
+* Just use the path for the return URL, so extra query parameters don't interfere [DHH]
+
-* Added a new default database-backed store after experiencing trouble with the filestore on NFS. The file store is still available as an option [DHH]
-

plugins/open_id_authentication/lib/open_id_authentication.rb

@@ -4 +4 @@
-  @@store = :db
-  mattr_accessor :store
+
+  class InvalidOpenId < StandardError
+  end
-
-  class Result
@@ -56 +59 @@
-      "http://" + url + "/"
-    else
-"#{url} is not a correctly formatted OpenID address"
+InvalidOpenId.new("#{url} is not an OpenID URL")
-    end
-  end
@@ -131 +134 @@
-      open_id_response.redirect_url(
-        request.protocol + request.host_with_port + "/",
-url
+protocol + request.host_with_port + request.path
-      )     
-    end

plugins/open_id_authentication/test/normalize_test.rb

@@ -1 +1 @@
-require 'test/unit'
+require 'rubygems'
+require 'active_support'
-
-RAILS_ROOT = File.dirname(__FILE__)
@@ -20 +22 @@
-    end
-  end
+  
+  def test_broken_open_id
+    assert_raises(InvalidOpenId) { normalize_url("=name") }
+  end
-end