Changeset 7056

Timestamp:

06/18/07 17:00:15 (1 year ago)

Author:

mislav

Message:

Prototype: mousewheel enhancements, updated TODO, test tweaks. It is no longer relevant whether you use window or document objects to attach the handler to - it works either way. (Mozilla/IE use document while Opera/Safari wants window). Both 'mousewheel' and 'DOMMouseScroll' are accepted as event types, but 'mousewheel' is preffered (for now).

Files:

• spinoffs/prototype/branches/event/src/event.js (modified) (5 diffs)
• spinoffs/prototype/branches/event/test/functional/event.html (modified) (2 diffs)
• spinoffs/prototype/branches/event/TODO (modified) (2 diffs)

spinoffs/prototype/branches/event/src/event.js

@@ -64 +64 @@
-  Object.extend(Observer.prototype, {
-    initialize: function(element, type, callback, useCapture) {
-
+
+
-      this.type     = this._type     = type;
-      this.callback = this._callback = callback;
@@ -73 +74 @@
-          if (B.IE || B.WebKit) this._type = 'keydown';
-          break;
-
+
+
-          if (B.IE) break;
-          this._type = type == 'mouseenter' ? 'mouseover' : 'mouseout';
-          this._callback = function(event) {
-            var rel = event.relatedTarget, cur = event.currentTarget;
-rel = (rel.nodeType == Node.TEXT_NODE) ? rel.parentNode : rel
-=
+if (rel.nodeType == Node.TEXT_NODE) rel = rel.parentNode
+
-              return callback.call(this, event); 
-          };
-          break;
-        case 'mousewheel':
+        case 'DOMMouseScroll':
+          if (B.IE || B.Opera) this._type = 'mousewheel';
+          else this._type = 'DOMMouseScroll';
+
-          if (B.IE) {
-// this.element == window ? document : this.element
+if (this.element == window) this._element = document;
-            this._callback = function(event) {
-              callback.call(this, event, event.wheelDelta/120);
-            }
-          } else {
-
+
+
-            this._callback = B.Opera ? function(event) {
-              callback.call(this, event, -event.wheelDelta/120);
@@ -102 +109 @@
-    add: function() {
-      if (this.type == 'DOMContentLoaded' && this.element == document) {
-
+
+
-      }
-      this._add();
@@ -155 +163 @@
-    Object.extend(Observer.prototype, {
-      _add: function() {
-
+
+
+
+
-      },
-      _remove: function() {
-
+
+
+
+
-      }
-    });
-    
+    // extend Event.prototype with our neat instance methods
-    Event.prototype = Event.prototype || document.createEvent("UIEvents").__proto__;
-    Object.extend(Event.prototype, instanceMethods);    
@@ -168 +183 @@
-      _add: function() {
-        // create a wrapper for scope correction and event object normalization
-
+_
-        this.wrapper = function(e) { return ob.call(el, klass.extendEvent(e, el)) };
-        // attach it
-
-
+_
+_
-        this.constructor.globalCache.push(this);
-      },
-      _remove: function() {
-
+_
-        else {
-          if (!this.wrapper) 
-
-
+_
+_
-        }
-      }

spinoffs/prototype/branches/event/test/functional/event.html

@@ -180 +180 @@
-        msg.update('<i>DETACHED</i>').setStyle({ color:'gray' });
-      },
-$('wheel')
+document
-    }
-  </script>
@@ -342 +342 @@
-  </script>
-  
-
+ <b>(incomplete)</b>
-  
-  <p id="custom_events_target">Lorem ipsum dolor sit amet.</p>

spinoffs/prototype/branches/event/TODO

@@ -1 @@
-
-
-
-
-
-
-
+
+
+
+
-* resolve special cases for mousewheel handling:
-  - window in IE
-  - document in Opera
+  - Opera & Safari won't fire the event on objects other than document
-* stopImmediatePropagation
-  http://www.w3.org/TR/2003/NOTE-DOM-Level-3-Events-20031107/events.html#Events-Event-stopImmediatePropagation
@@ -14 +12 @@
-            https://prototype.campfirenow.com/room/73745/transcript/message/23651995#message_23651995
-* Custom events for adding/removing class names, updating elements, etc.
+
+
+Useful resources
+----------------
+
+  http://www.quirksmode.org/dom/w3c_events.html
+  http://del.icio.us/mislav/events
+  http://dev.opera.com/articles/javascript/